Hi Manju, In the subject line, calling mach/dm646x.h obsolete is not right since as of this patch mach/dm646x.h still exists. On Thu, Dec 15, 2011 at 17:41:50, Hadli, Manjunath wrote: > remove inclusion of header files from vpif.h and vpif_dispaly.c > and add appropriate header file for building. The main purpose of the patch is to remove machine specific includes from driver files since that (among other things) comes in the way of platform code consolidation. This needs to come out in the description. Right now the description is just describing the change without answering the question - why? > > Signed-off-by: Manjunath Hadli <manjunath.hadli@xxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> > Cc: LMML <linux-media@xxxxxxxxxxxxxxx> > --- > drivers/media/video/davinci/vpif.h | 2 +- > drivers/media/video/davinci/vpif_display.c | 2 -- > 2 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/video/davinci/vpif.h b/drivers/media/video/davinci/vpif.h > index 25036cb..c96268a 100644 > --- a/drivers/media/video/davinci/vpif.h > +++ b/drivers/media/video/davinci/vpif.h > @@ -19,7 +19,7 @@ > #include <linux/io.h> > #include <linux/videodev2.h> > #include <mach/hardware.h> It appears mach/hardware.h can be removed as well. Can you please check? > -#include <mach/dm646x.h> > +#include <linux/i2c.h> I2C is actually needed by include/media/davinci/vpif_types.h so it should go there. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
