Re: [PATCH 2/3] drxk: correction frontend attatching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 17 December 2011 21:57:16 linuxtv@xxxxxxxxxxxxxxx wrote:
> From: Stefan Ringel <linuxtv@xxxxxxxxxxxxxxx>
> 
> all drxk have dvb-t, but not dvb-c.
> 
> Signed-off-by: Stefan Ringel <linuxtv@xxxxxxxxxxxxxxx>
> ---
>  drivers/media/dvb/frontends/drxk_hard.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c
> index 038e470..8a59801 100644
> --- a/drivers/media/dvb/frontends/drxk_hard.c
> +++ b/drivers/media/dvb/frontends/drxk_hard.c
> @@ -6460,9 +6460,11 @@ struct dvb_frontend *drxk_attach(const struct drxk_config *config,
>  	init_state(state);
>  	if (init_drxk(state) < 0)
>  		goto error;
> -	*fe_t = &state->t_frontend;
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  
> -	return &state->c_frontend;
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
> +	if (state->m_hasDVBC)
> +		*fe_t = &state->c_frontend;
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +	return &state->t_frontend;
               ^^^^^^^^^^^^^^^^^^^     
>  
>  error:
>  	printk(KERN_ERR "drxk: not found\n");

NAK, this changes the behaviour for existing drivers.

What is the point to swap DVB-T and DVB-C frontends?
If you really need this, please add an option to the config struct
with default that does not change anything for existing drivers.

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux