Hi Sylwester, On Sun, Dec 04, 2011 at 04:16:12PM +0100, Sylwester Nawrocki wrote: > Change the V4L2_CID_FOCUS_AUTO control type from boolean to a menu > type. In case of boolean control we had values 0 and 1 corresponding > to manual and automatic focus respectively. > > The V4L2_CID_FOCUS_AUTO menu control has currently following items: > 0 - V4L2_FOCUS_MANUAL, > 1 - V4L2_FOCUS_AUTO, > 2 - V4L2_FOCUS_AUTO_MACRO, > 3 - V4L2_FOCUS_AUTO_CONTINUOUS. I would put the macro mode to a separate menu since it's configuration for how the regular AF works rather than really different mode. ... > @@ -567,6 +576,7 @@ const char *v4l2_ctrl_get_name(u32 id) > case V4L2_CID_PRIVACY: return "Privacy"; > case V4L2_CID_IRIS_ABSOLUTE: return "Iris, Absolute"; > case V4L2_CID_IRIS_RELATIVE: return "Iris, Relative"; > + case V4L2_CID_DO_AUTO_FOCUS: return "Do Auto Focus"; I'd perhaps use "begin" or "start". How does the user learn the autofocus has finished? I think this looks like quite similar problem than telling the flash strobe status to the user. The solution could also be similar to that. Cheers, -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
