On Monday 14 November 2011 20:39:48 Manu Abraham wrote: > On 11/12/11, Andreas Oberritter <obi@xxxxxxxxxxx> wrote: > > On 11.11.2011 23:38, Mauro Carvalho Chehab wrote: > >> Em 11-11-2011 20:07, Manu Abraham escreveu: > >>> On Fri, Nov 11, 2011 at 3:42 PM, Mauro Carvalho Chehab > >>> <mchehab@xxxxxxxxxx> wrote: > >>>> Em 11-11-2011 04:26, Manu Abraham escreveu: > >>>>> On Fri, Nov 11, 2011 at 2:50 AM, Mauro Carvalho Chehab > >>>>> <mchehab@xxxxxxxxxx> wrote: > >>>>>> Em 10-11-2011 13:30, Manu Abraham escreveu: > >>>>> The purpose of the patch is to > >>>>> query DVB delivery system capabilities alone, rather than DVB frontend > >>>>> info/capability. > >>>>> > >>>>> Attached is a revised version 2 of the patch, which addresses the > >>>>> issues that were raised. > >>>> > >>>> It looks good for me. I would just rename it to DTV_SUPPORTED_DELIVERY. > >>>> Please, when submitting upstream, don't forget to increment DVB version > >>>> and > >>>> add touch at DocBook, in order to not increase the gap between API specs > >>>> and the > >>>> implementation. > >>> > >>> Ok, thanks for the feedback, will do that. > >>> > >>> The naming issue is trivial. I would like to have a shorter name > >>> rather that SUPPORTED. CAPS would have been ideal, since it refers to > >>> device capability. > >> > >> CAPS is not a good name, as there are those two CAPABILITIES calls there > >> (well, currently not implemented). So, it can lead in to some confusion. > >> > >> DTV_ENUM_DELIVERY could be an alternative for a short name to be used > >> there. > > > > I like "enum", because it suggests that it's a read-only property. > > > > DVB calls them "delivery systems", so maybe DTV_ENUM_DELSYS may be an > > alternative. > > This is a bit more sensible and meaningful than the others. I like > this one better than the others. > > Attached is a version 3 patch which addresses all the issues that were raised. Fine for me. (I do not care about the name of the game.) Acked-by: Oliver Endriss <o.endriss@xxxxxx> CU Oliver -- ---------------------------------------------------------------- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ ---------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
