On Sat, 2011-11-12 at 21:36 +0200, Antti Palosaari wrote: > On 11/12/2011 08:22 PM, Malcolm Priestley wrote: > > On Sat, 2011-11-12 at 18:18 +0200, Antti Palosaari wrote: > >> On 11/12/2011 05:55 PM, Malcolm Priestley wrote: > >>> Remove get config from probe and move to identify_state. > >>> > >>> intf->cur_altsetting->desc.bInterfaceNumber is always expected to be zero, so there > >>> no point in checking for it. > >> > >> Are you sure? IIRC there is HID remote on interface 1 or 2 or so (some > >> other than 0). Please double check. > >> > >>> Calling from probe seems to cause a race condition with some USB controllers. > >> > >> Why? > >> > > Is some other module going to claim the device? > > > > Would it not be better use usb_set_interface to set it back to 0? > > I spoke too soon, there is someone else about. On boot input claims interface 1 Nov 13 11:43:36 tvbox kernel: [ 1.830276] input: Afatech DVB-T 2 as /devices/pci0000:00/0000:00:06.1/usb2/2-4/2-4:1.1/input/input2 Nov 13 11:43:36 tvbox kernel: [ 1.830367] generic-usb 0003:1B80:E399.0001: input,hidraw0: USB HID v1.01 Keyboard [Afatech DVB-T 2] on usb-0000:00:06.1-4/input1 ... Nov 13 11:43:38 tvbox kernel: [ 19.151700] dvb-usb: found a 'KWorld PlusTV Dual DVB-T Stick (DVB-T 399U)' in cold state, will try to load a firmware ... Nov 13 11:43:39 tvbox kernel: [ 20.313483] input: IR-receiver inside an USB DVB receiver as /devices/pci0000:00/0000:00:06.1/usb2/2-4/rc/rc0/input8 Nov 13 11:43:39 tvbox kernel: [ 20.313528] rc0: IR-receiver inside an USB DVB receiver as /devices/pci0000:00/0000:00:06.1/usb2/2-4/rc/rc0 Nov 13 11:43:39 tvbox kernel: [ 20.313530] dvb-usb: schedule remote query interval to 500 msecs. Nov 13 11:43:39 tvbox kernel: [ 20.313534] dvb-usb: KWorld PlusTV Dual DVB-T Stick (DVB-T 399U) successfully initialized and connected. So, a usb_set_interface is needed to make sure we on interface 0 and remain there. Regards Malcolm -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
