Re: [PATCH 2/7] af9015 Remove call to get config from probe.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2011-11-12 at 18:18 +0200, Antti Palosaari wrote:
> On 11/12/2011 05:55 PM, Malcolm Priestley wrote:
> > Remove get config from probe and move to identify_state.
> >
> > intf->cur_altsetting->desc.bInterfaceNumber is always expected to be zero, so there
> > no point in checking for it.
> 
> Are you sure? IIRC there is HID remote on interface 1 or 2 or so (some 
> other than 0). Please double check.
> 
> > Calling from probe seems to cause a race condition with some USB controllers.
> 
> Why?
> 
Is some other module going to claim the device?

Would it not be better use usb_set_interface to set it back to 0? 

Rather than failing it back to the user.

Regards


Malcolm

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux