On Thu, Oct 20, 2011 at 2:14 PM, Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> wrote: > On Thu, Oct 20, 2011 at 1:08 PM, Janne Grunau <j@xxxxxxxxxx> wrote: >> I think such scenario is unlikely but I don't know it for sure and >> I don't want to force anyone to test every firmware version. >> Ignoring them for firmware version < 16 should be safe since we assume >> they had no effect. Returning -EINVAL might break API-ignoring >> applications written with the HD PVR in mind but I think it's a better >> approach than silently ignoring those controls. > > At this point, let's just make it so that the old behavior is > unchanged for old firmwares, meaning from both an API standpoint as > well as what the values are. At some point if somebody cares enough > to go back and fix the support so that the controls actually work with > old firmwares, they can take that up as a separate task. In reality, > it is likely that nobody will ever do that, as the "easy answer" is > just to upgrade to firmware 16. > > Taylor, could you please tweak your patch to that effect and resubmit? > Sure, I'll try to get to it tonight and have it tested. Regards. -- Taylor -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html