Re: [uclinux-dist-devel] [PATCH 4/4] v4l2: add blackfin capture bridge driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 14 Sep 2011, Scott Jiang wrote:

> > i think at least these three are unused and should get punted
> >
> >> +static int __devinit bcap_probe(struct platform_device *pdev)
> >> +{
> >> +       struct bcap_device *bcap_dev;
> >> +       struct video_device *vfd;
> >> +       struct i2c_adapter *i2c_adap;
> >
> > you need to include linux/i2c.h for this
> >
> no, bfin_capture.h already contains this.

It doesn't matter. You're supposed to _explicitly_ include every header, 
that is required to build your code.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux