On Tue, Sep 13, 2011 at 14:34, Scott Jiang wrote:
> --- /dev/null
> +++ b/drivers/media/video/blackfin/Kconfig
> @@ -0,0 +1,10 @@
> +config VIDEO_BLACKFIN_CAPTURE
> + tristate "Blackfin Video Capture Driver"
> + depends on VIDEO_DEV && BLACKFIN
> + select VIDEOBUF2_DMA_CONTIG
since the code needs i2c, this needs to list I2C under depends
> --- /dev/null
> +++ b/drivers/media/video/blackfin/bfin_capture.c
>
> +#include <linux/moduleparam.h>
> +#include <linux/version.h>
> +#include <linux/clk.h>
i think at least these three are unused and should get punted
> +static int __devinit bcap_probe(struct platform_device *pdev)
> +{
> + struct bcap_device *bcap_dev;
> + struct video_device *vfd;
> + struct i2c_adapter *i2c_adap;
you need to include linux/i2c.h for this
> +static struct platform_driver bcap_driver = {
> + .driver = {
> + .name = CAPTURE_DRV_NAME,
> + .owner = THIS_MODULE,
> + },
> + .probe = bcap_probe,
> + .remove = __devexit_p(bcap_remove),
> +};
no suspend/resume ? :)
> +MODULE_DESCRIPTION("Analog Devices video capture driver");
should mention the device part name in the desc
> --- /dev/null
> +++ b/drivers/media/video/blackfin/ppi.c
>
> +struct ppi_if *create_ppi_instance(const struct ppi_info *info)
> +void delete_ppi_instance(struct ppi_if *ppi)
should be ppi_{create,delete}_instance to match existing ppi_xxx style
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
