Hi Andy, On Tuesday 06 September 2011 12:50:25 Andy Shevchenko wrote: > On Tue, 2011-09-06 at 13:46 +0300, Andy Shevchenko wrote: > > On Tue, 2011-09-06 at 12:25 +0200, Laurent Pinchart wrote: > > > I've slightly modified 1/5 and 3/5 (the first one returned -1 from > > > media_enum_entities(), which made media-ctl stop with a failure > > > message) and pushed the result to the repository. > > > > Okay. I looked at them. > > One minor comment: udef_unref is aware of NULL. I wasn't aware of that, thanks. > Ah, and another. I don't get why you split snprintf() to that suboptimal > strncpy + x[sizeof(x)-1] = 0? snprintf needs to parse the format argument, is strncpy really suboptimal ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
