Re: [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em 01-09-2011 09:45, Andrew Goff escreveu:
> Hi Thierry,
> 
> I have been having problems with the radio tuner in my leadtek 1800h card. This card has the xc2028 tuner. Using fmtools i would get an error message similar to - frequency out of range 0.0 - 0.0.

This is due to a bug at the tuner core.

> After seeing you patches at the beginning of last month I installed the recent drivers at the time and applied your patches. The frequency out of range error went away but the only sound I got was static. I then discovered the frequency is out by 2.7MHz, so if I want to listen to 104.9 I need to tune the radio to 107.6.

Try to remove Thierry xc3028 patch. His patches were applied already at the main tree
(I applied them very early today).

> 
> On Ubuntu 10.04 the card works fine, the errors started when applying the recent V4L drivers that I require for another card.
> 
> Are you able to help resolve this problem and get this card working properly again.
> 
> Thanks
> 
> Andrew
> 
> 
> 
> On 1/09/2011 3:10 PM, Thierry Reding wrote:
>> * Mauro Carvalho Chehab wrote:
>>> Em 04-08-2011 04:14, Thierry Reding escreveu:
>>>> In radio mode, no frequency offset is needed. While at it, split off the
>>>> frequency offset computation for digital TV into a separate function.
>>>
>>> Nah, it is better to keep the offset calculation there. there is already
>>> a set_freq for DVB. breaking the frequency logic even further seems to
>>> increase the driver's logic. Also, patch is simpler and easier to review.
>>
>> Okay, no problem. Feel free to replace the patch with yours.
>>
>>> The patch bellow seems to be better. On a quick review, I think that the
>>>     send_seq(priv, {0x00, 0x00})
>>> sequence may be wrong. I suspect that the device is just discarding that,
>>> but changing it needs more testing.
>>
>> I ran across that as well, but I didn't dare touch it because I wasn't sure
>> what the broader impact would be.
>>
>> Thierry

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux