* Mauro Carvalho Chehab wrote: > Em 04-08-2011 04:14, Thierry Reding escreveu: > > In radio mode, no frequency offset is needed. While at it, split off the > > frequency offset computation for digital TV into a separate function. > > Nah, it is better to keep the offset calculation there. there is already > a set_freq for DVB. breaking the frequency logic even further seems to > increase the driver's logic. Also, patch is simpler and easier to review. Okay, no problem. Feel free to replace the patch with yours. > The patch bellow seems to be better. On a quick review, I think that the > send_seq(priv, {0x00, 0x00}) > sequence may be wrong. I suspect that the device is just discarding that, > but changing it needs more testing. I ran across that as well, but I didn't dare touch it because I wasn't sure what the broader impact would be. Thierry
Attachment:
pgpBzjD4cEmuB.pgp
Description: PGP signature