On Sat, Aug 13, 2011 at 11:37:40PM +0300, Sakari Ailus wrote:
> Hi Laurent,
> On Fri, Aug 12, 2011 at 10:38:35PM +0200, Laurent Pinchart wrote:
> > drivers/media/video/omap3isp/isp.h is not a proper location for a header
> > that needs to be included from board code. Move the platform data
> > definitions to media/omap3isp.h.
> >
> > Board code still needs to include isp.h to get the struct isp_device
> > definition and access OMAP3 ISP platform callbacks. Those callbacks will
> > be replaced by more generic code.
>
> Thanks for the patch! I very much agree with the approach.
[clip]
> > +struct isp_platform_data {
> > + struct isp_v4l2_subdevs_group *subdevs;
> > + void (*set_constraints)(struct isp_device *isp, bool enable);
> > +};
>
> I applied this to my rx51 tree (yeah, nasty out-of-tree stuff, for now), and
> get a bunch of errors, mostly because of missing definitions. Have you
> tested the patch somewhere? :-)
>
> At least these should be present, I think:
>
> - v4l2_dev_to_isp_device
> - isp_platform_callback
> - ISP_XCLK_*
After reading the patch description and some thought,
Acked-by: Sakari Ailus <sakari.ailus@xxxxxx>
--
Sakari Ailus
sakari.ailus@xxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
