On Wed, Jul 27, 2011 at 07:51:36PM +0200, Laurent Pinchart wrote: > Hi Sakari, Hi Laurent, > On Wednesday 27 July 2011 12:13:05 Sakari Ailus wrote: > > Hi Laurent, > > > > Thanks for the patch. I have a few comments below. > > Thanks for the review. Please see my answers to your comments below. Javier, > there's one question for you as well. In my opinion the patch looks very good and clean in general. All my comments were small issues and I agree with the resolutions. I think implementing dynamic pll calculation and digital gain control may be postponed if you wish. Especially the latter would be nice since I think many sensors have that feature (plus colour component gains) but no driver expose any proper interface for it. -- Sakari Ailus sakari.ailus@xxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
