On 06/28/2011 03:47 PM, Guennadi Liakhovetski wrote:
Hi Robert Hope you don't mind me resuming an almost 3 year old mail thread;) I'm referring to your patches to soc-camera core and pxa-camera, adding PM support to them. Below is your message again, explaining, why the standard pm hooks cannot be used to suspend and resume the camera host and the camera sensor. While trying to make soc-camera play nicer with the V4L2 generic framework, I was trying to eliminate as many redundant pieces from soc-camera as possible and replace them with standard methods. This made me re-consider those your patches. Let's have a look at your argumentation: So, we currently have 3 instances: soc-camera bus, i2c bus, and pxa-camera platform device driver. You say, i2c resumes as first, then at some point pxa-camera and soc-camera - in this or reverse order. This is why we cannoe use i2c-resume to bring the sensor up before pxa-camera has restored its master clock. So, currently we hook onto the soc-camera bus, which then calls pxa-camera's resume, which then restores camera host's state and resumes the sensor. Now, the question: wouldn't this also work, if we eliminate the soc-camera resume path? And instead just used pxa-camera resume method to bring up the sensor? Coule you please test the below patch?
Tested and working, the resume works OK, which means your thinking is good :)
Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
