Re: [PATCH] Revert "[media] v4l2: vb2: one more fix for REQBUFS()"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Marek,

On Wed, Jun 08, 2011 at 11:25:50AM +0200, Marek Szyprowski wrote:
> This reverts commit 31901a078af29c33c736dcbf815656920e904632.
> 
> Queue should be reinitialized on each REQBUFS() call even if the memory
> access method and buffer count have not been changed. The user might have
> changed the format and if we go the short path introduced in that commit,
> the memory buffer will not be reallocated to fit with new format.
> 
> The previous patch was just over-engineered optimization, which just
> introduced a bug to videobuf2.
> 
> Reported-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> CC: Pawel Osciak <pawel@xxxxxxxxxx>
Didn't see your patch before I posted mine. (I only checked my inbox, not
the linux-media folder). So take it as an Ack.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux