On Tue, 7 Jun 2011, Kassey Lee wrote:
> Guennadi
>
> thanks for your comments very much! I will update the V3 patch later.
>
>
> On Fri, Jun 3, 2011 at 6:22 PM, Guennadi Liakhovetski
> <g.liakhovetski@xxxxxx> wrote:
> > Ok, this will be converted to use a common "cafe" code, but I'll comment
> > on this version anyway, for your future reference.
> >
> > On Wed, 1 Jun 2011, Kassey Lee wrote:
[snip]
> >
> > Did you remove your pass-through code here on purpose or because you
> > misunderstood my comment? I meant, that in your original code
> >
> Sorry, I misunderstood your comment, do you mean remove the wrong comment only ?
Yes.
> > + /* Generic pass-through */
> > + formats++;
> > + if (xlate) {
> > + xlate->host_fmt = fmt;
> > + xlate->code = code;
> > + xlate++;
> > + }
> >
> > the comment "generic" was wrong, because in generic case you run on
> > default case above and bail out. However, that block allowed you to use
> > the "standard" V4L2_MBUS_FMT_YUYV8_2X8 -> V4L2_PIX_FMT_YUYV conversion, or
> > is it not supported by your hardware / driver?
> >
> it is supported.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
