On Tue, 7 Jun 2011, Kassey Lee wrote: > hi, Jon: > thanks for your work! it is good to know that your brought up > MMP2(610) SoC with OV7670 > I have some questions: > 1) this driver is still based on cafe_ccic.c, as you said, we > can abstract the low level register function, and use soc_camera and > videofbu2 to manage the buff and state machine, how do you think ? Right, _if_ you really want to usesoc-camera and videobuf2 with your new driver, which you're certainly very welcome to do, all the v4l interfacing has to be removed from the core. Otherwise you can consider re-using it and just implementing a complete v4l2 video bridge / host driver. That's up to you. > 2) i2c_adapter, how about move this code to driver/i2c, then > ccic driver will become clean? Not sure, what other V4L drivers do? Don't they implement their I2C adapters internally under drivers/video? > 3) in mmp_driver.c, it has the sensor name, OV7670, we wish > that ccic driver do not need to aware of the sensor, also we need to > support front and back camera sensor cases. Yes, that hard-coded bond has to be removed. Thanks Guennadi > > Guennadi, what is your suggestions ? > > great thanks! > > > On Tue, Jun 7, 2011 at 6:39 AM, Jonathan Corbet <corbet@xxxxxxx> wrote: > > Hello, all, > > > > As I promised last week, here's the state of my work refactoring the Cafe > > driver and adding Armada 610 support. I intend to have them ready for 3.1, > > but they are not ready for merging yet. There's a couple of things I'd > > like to clean up, and I'd like to let the OLPC people test things a bit > > more. But I figured it would be good to get it out there for comments. > > > > Essentially, Marvell has taken the camera controller from the old Cafe chip > > and dropped it into some ARM SoC setups, one of which is the Armada 610. I > > pondered just making a new driver, but, given that the controller has > > changed very little, it made a lot more sense to reuse the existing code. > > > > The patches here split cafe_ccic.c into "platform" and "core" pieces while > > leaving functionality unchanged. The new "mmp-camera" driver is then added > > as a second platform. > > > > This work is not done; at a minimum, I plan to convert it over to videobuf2 > > and make use of the Armada's s/g DMA capabilities. Doubtless there is > > plenty more to be done; I would also sure like to see Kassey Lee's Marvell > > driver integrated with this one if at all possible. > > > > Comments? > > > > Thanks, > > > > jon > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-media" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > > -- > Best regards > Kassey > Application Processor Systems Engineering, Marvell Technology Group Ltd. > Shanghai, China. > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
