On Friday, June 03, 2011 21:55:59 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Wednesday 25 May 2011 15:33:48 Hans Verkuil wrote: > > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > > > This more generic function makes it possible to have a single function > > that takes care of flags handling, in particular with regards to sending > > a control event when the flags change. > > > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > --- > > [snip] > > > +/** v4l2_ctrl_flags_lock() - Clear and set flags for a control. > > + * @ctrl: The control whose flags should be changed. > > + * @clear_flags: Mask out these flags. > > + * @set_flags: Set these flags. > > * > > - * This sets or clears the V4L2_CTRL_FLAG_GRABBED flag atomically. > > - * Does nothing if @ctrl == NULL. > > - * This will usually be called when starting or stopping streaming in the > > - * driver. > > + * This clears and sets flags. Does nothing if @ctrl == NULL. > > * > > - * This function can be called regardless of whether the control handler > > - * is locked or not. > > + * This function expects that the control handler is unlocked and will > > lock + * it before changing flags. > > */ > > -void v4l2_ctrl_grab(struct v4l2_ctrl *ctrl, bool grabbed); > > +void v4l2_ctrl_flags_lock(struct v4l2_ctrl *ctrl, u32 clear_flags, u32 > > set_flags); > > The v4l2_ctrl_flags_lock() function doesn't seem to be used. Do we need it ? > > It is likely that I will (partially?) revert this patch. The idea for v4l2_ctrl_flags(_lock) was to simplify changing the READ_ONLY flag on the fly for autofoo/foo type controls. But I've changed my opinion on that. See also the mail I sent earlier: http://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg32332.html Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
