Re: [RFCv2 PATCH 05/11] v4l2-ctrls: add v4l2_fh pointer to the set control functions.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, June 03, 2011 21:55:23 Laurent Pinchart wrote:
> Hi Hans,
> 
> Thanks for the patch.
> 
> On Wednesday 25 May 2011 15:33:49 Hans Verkuil wrote:
> > From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> > 
> > When an application changes a control you want to generate an event.
> > However, you want to avoid sending such an event back to the application
> > (file handle) that caused the change.
> > 
> > Add the filehandle to the various set control functions.
> 
> To implement per-file handle controls, the get/try functions will need the 
> file handle as well. Should this patch handle that, or do you want to postpone 
> it until a driver uses per-file handle controls ?

No, this has nothing to do with per-filehandle controls. This filehandle is
needed to prevent events from being sent to the filehandle that caused the
change (leads to nasty feedback-loops). Since get and try will never raise
control events I do not need the filehandle there.

It's patches 3/11 and 11/11 that actually add support for per-filehandle controls.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux