Em 23-05-2011 15:50, Hans Petter Selasky escreveu: > On Monday 23 May 2011 20:29:28 Mauro Carvalho Chehab wrote: >> Em 23-05-2011 15:23, Guennadi Liakhovetski escreveu: >>> On Mon, 23 May 2011, Hans Petter Selasky wrote: >>>> --HPS >>> >>> (again, inlining would save me copy-pasting) >> >> Yeah... hard to comment not-inlined patches... >> >>>> -inline u32 stb0899_do_div(u64 n, u32 d) >>>> +static inline u32 stb0899_do_div(u64 n, u32 d) >>> >>> while at it you could as well remove the unneeded in a C file "inline" >>> attribute. >> >> hmm... foo_do_div()... it seems to be yet-another-implementation >> of asm/div64.h. If so, it is better to just remove this thing >> and use the existing function. >> > > The reason for this patch is that some version of GCC generated some garbage > code on this function under certain conditions. Removing inline completly on > this static function in a C file is fine by me. Do I need to create another > patch? Just looked inside the code: it is not re-implementing the wheel. I don't like such macros, but it should not hurt. So, I just applied your patch. Thanks, Mauro. > > --HPS > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
