Re: [PATCH] Inlined functions should be static.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em 23-05-2011 15:23, Guennadi Liakhovetski escreveu:
> On Mon, 23 May 2011, Hans Petter Selasky wrote:
> 
>> --HPS
>>
> 
> (again, inlining would save me copy-pasting)

Yeah... hard to comment not-inlined patches...

> 
>> -inline u32 stb0899_do_div(u64 n, u32 d)
>> +static inline u32 stb0899_do_div(u64 n, u32 d)
> 
> while at it you could as well remove the unneeded in a C file "inline" 
> attribute.

hmm... foo_do_div()... it seems to be yet-another-implementation
of asm/div64.h. If so, it is better to just remove this thing
and use the existing function.

> 
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux