> Hi Laurent, > > On Tue, May 10, 2011 at 5:42 AM, Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: >>> >> Why is there no enum_input operation in v4l2_subdev_video_ops? >> >> Why do you need one ? > > Because I want to query decoder how many inputs it can support. > So the question is where we should store inputs info, board specific data > or decoder driver? > I appreciate your advice. ENUMINPUT as defined by V4L2 enumerates input connectors available on the board. Which inputs the board designer hooked up is something that only the top-level V4L driver will know. Subdevices do not have that information, so enuminputs is not applicable there. Of course, subdevices do have input pins and output pins, but these are assumed to be fixed. With the s_routing ops the top level driver selects which input and output pins are active. Enumeration of those inputs and outputs wouldn't gain you anything as far as I can tell since the subdevice simply does not know which inputs/outputs are actually hooked up. It's the top level driver that has that information (usually passed in through board/card info structures). Regards, Hans >>> > Maybe because noone needed it until now? >>> > >>> >> I found some drivers put this info in board specific data, but in my >>> >> opinion this info is sensor or decoder related. >>> > >>> > Can you tell which drivers / boards you're referring to? >>> >>> I referred to drivers/media/video/davinci files. >>> >>> >> So it should be put into the sensor drivers. >>> > >>> > Maybe. Also notice, I'm not a maintainer nor a principal v4l2-subdev >>> > developer. I've added Hans and Laurent to Cc:, will see what they >>> say, or >>> > you can just point out which drivers / platforms are doing this wrong >>> and >>> > propose a fix. >>> >>> Sorry, I only found your mail in MAINTAINERS. >> > > Regards, > Scott > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html