Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dnia poniedziaÅek 11 kwiecieÅ 2011 o 18:58:51 Guennadi Liakhovetski napisaÅ(a):
> On Mon, 11 Apr 2011, Aguirre, Sergio wrote:
> > 
> > Ok. And how about the attached patch? Would that work?
> 
> Yes, I think, ot would work too, only the call to
> soc_camera_xlate_by_fourcc() in the S_FMT case is superfluous, after
> ici->ops->set_fmt() we already have it in icd->current_fmt->host_fmt.
> Otherwise - yes, we could do it this way too. Janusz, could you test,
> please?

Looks like not based on the current mainline (-rc2) tree:

  CHECK   drivers/media/video/soc_camera.c
drivers/media/video/soc_camera.c:146:9: error: undefined identifier 'pixfmtstr'
  CC      drivers/media/video/soc_camera.o
drivers/media/video/soc_camera.c: In function 'soc_camera_try_fmt':
drivers/media/video/soc_camera.c:146: error: implicit declaration of function 'pixfmtstr'
drivers/media/video/soc_camera.c:146: warning: too few arguments for format
drivers/media/video/soc_camera.c: In function 'soc_camera_try_fmt_vid_cap':
drivers/media/video/soc_camera.c:180: warning: unused variable 'ici'

Thanks,
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux