On 10 March 2011 16:24, Jonathan Corbet <corbet@xxxxxxx> wrote: > Did the check need to move for some reason? If so, a one-of-these-days > nice feature might be to allow changing override_serial at run time. Yes. Otherwise the check would execute if that driver is loaded on XO-1. The check either had to be modified or moved into a place where we know we're on the right hardware. I chose the latter. You can still unload the module and reload with a different setting if needed. I haven't heard of anyone using the module param now that the firmware sets the bit correctly and new serial adapters have been widely distributed, making the selection between camera and serial fully automatic. Thanks for the review. Mauro, please merge. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html