[Trying to bash my inbox into reasonable shape, sorry for the slow response...] On Thu, 3 Mar 2011 19:03:31 +0000 (GMT) Daniel Drake <dsd@xxxxxxxxxx> wrote: > The code that checks the OLPC serial port is never built at the moment, > because CONFIG_OLPC_XO_1_5 doesn't exist and probably won't be added. > > Fix it so that it gets compiled in, only executes on OLPC laptops, and > move the check into the probe routine. > > The compiler is smart enough to eliminate this code when CONFIG_OLPC=n > (due to machine_is_olpc() always returning false). Getting rid of the nonexistent config option is clearly the right thing to do. I only wonder about moving the check to viacam_probe(). The nice thing about having things fail in viacam_init() is that, if the camera is not usable, the module will not load at all. By the time you get to viacam_probe(), the module is there but not will be useful for anything. Did the check need to move for some reason? If so, a one-of-these-days nice feature might be to allow changing override_serial at run time. Regardless, the behavior change only affects OLPC folks using the serial line, so I'm OK with it. Acked-by: Jonathan Corbet <corbet@xxxxxxx> Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
