Hi,
On Monday 10 January 2011 23:34:36 Hans Verkuil wrote:
> On Monday, January 10, 2011 23:18:26 Roberto Rodriguez Alcala wrote:
[snip]
> > diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> > index 5f6f470..0df8a9f 100644
> > --- a/include/linux/videodev2.h
> > +++ b/include/linux/videodev2.h
> > @@ -1300,6 +1300,8 @@ enum v4l2_exposure_auto_type {
> >
> > #define V4L2_CID_IRIS_ABSOLUTE (V4L2_CID_CAMERA_CLASS_BASE+17)
> > #define V4L2_CID_IRIS_RELATIVE (V4L2_CID_CAMERA_CLASS_BASE+18)
> >
> > +#define V4L2_CID_NIGHT_MODE
> > (V4L2_CID_CAMERA_CLASS_BASE+19) +
> >
> > /* FM Modulator class control IDs */
> > #define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900)
> > #define V4L2_CID_FM_TX_CLASS (V4L2_CTRL_CLASS_FM_TX | 1)
>
> This control also needs to be documented in
> Documentation/DocBook/v4l/controls.xml.
>
> However, reading up a bit on this I wonder whether this shouldn't be a
> 'Camera Mode' menu control since there can be a lot of different modes:
>
> http://www.digital-photography-school.com/digital-camera-modes
>
> Also, how does this relate to controls like EXPOSURE_AUTO? Will selecting
> manual exposure automatically turn off Night Mode? Or the inverse, will
> selecting Night Mode automatically turn on autoexposure?
I'm in favor of a Camera Mode menu control, but we need to define the
semantics of modes properly, and especially how they relate to other controls.
Modes tend to be high-level controls that are usually implemented in software,
so they will definitely have an influence on many low-level controls.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
