an 11, 2011 at 4:54 PM, Felipe Balbi <balbi@xxxxxx> wrote: > Hi, > > On Tue, Jan 11, 2011 at 06:31:23AM -0500, manjunatha_halli@xxxxxx wrote: >> From: Manjunatha Halli <manjunatha_halli@xxxxxx> >> >> These are the sources for the common interfaces required by the >> FM V4L2 driver for TI WL127x and WL128x chips. >> >> These implement the FM channel-8 protocol communication with the >> chip. This makes use of the Shared Transport as its transport. >> >> Signed-off-by: Manjunatha Halli <manjunatha_halli@xxxxxx> >> Reviewed-by: Hans Verkuil <hverkuil@xxxxxxxxx> > > looks like this is implementing a "proprietary" (by that I mean: for > this driver only) IRQ API. Why aren't you using GENIRQ with threaded > IRQs support ? > > Core IRQ Subsystem would handle a lot of stuff for you. There is no concept of Interrupts/IRQ as such here, Hence no question of using GENIRQ. The FM device WL128x is interfaced via the UART, (Internally inside the WL128x chip the BT-core on the chip communicates with FM chip via i2C, and would have dedicated interrupt lines may be...) So, Whenever we refer to interrupt or IRQ or handlers in the driver, It pretty much means a receive callback for the UART frame which constitutes the FM interrupt event. i.e FM interrupt would have occurred, If I receive a frame over UART which starts with 0x08 as 1st byte and has 0xFF as its 3rd byte. I hope this clarifies the non-usage of GENIRQ with threaded support. > -- > balbi > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Regards Halli -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
