On Monday 10 January 2011 15:00:18 BjÃrn Mork wrote:
> Oliver Endriss <o.endriss@xxxxxx> writes:
>
> > + case 18:
> > + size = 0;
> > + fw_name = "ngene_18.fw";
> > + break;
> > }
> >
> > if (request_firmware(&fw, fw_name, &dev->pci_dev->dev) < 0) {
> > @@ -1266,6 +1270,8 @@ static int ngene_load_firm(struct ngene *dev)
> > ": Copy %s to your hotplug directory!\n", fw_name);
> > return -1;
> > }
> > + if (size == 0)
> > + size = fw->size;
> > if (size != fw->size) {
> > printk(KERN_ERR DEVICE_NAME
> > ": Firmware %s has invalid size!", fw_name);
>
>
> Just a stupid question: Why remove the size verification for version 18
> while keeping it for the other firmware revisions?
Good point. This was handy when the firmware was developed.
I will submit an additional patch which adds a size check for Fw18.
CU
Oliver
--
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
