Re: [PATCH 03/16] ngene: Firmware 18 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Endriss <o.endriss@xxxxxx> writes:

> +	case 18:
> +		size = 0;
> +		fw_name = "ngene_18.fw";
> +		break;
>  	}
>  
>  	if (request_firmware(&fw, fw_name, &dev->pci_dev->dev) < 0) {
> @@ -1266,6 +1270,8 @@ static int ngene_load_firm(struct ngene *dev)
>  			": Copy %s to your hotplug directory!\n", fw_name);
>  		return -1;
>  	}
> +	if (size == 0)
> +		size = fw->size;
>  	if (size != fw->size) {
>  		printk(KERN_ERR DEVICE_NAME
>  			": Firmware %s has invalid size!", fw_name);


Just a stupid question:  Why remove the size verification for version 18
while keeping it for the other firmware revisions?


BjÃrn

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux