On 12/29/2010 08:50 AM, Hyunwoong Kim wrote:
> This patch fixes the value of FIFO_CTRL in MSCTRL.
> Main-scaler has the value to specify a basis FIFO control of input DMA.
>
> The description of FIFO_CTRL has been changed as below.
> 0 = FIFO Empty (Next burst transaction is possible when FIFO is empty)
> 1 = FIFO Full (Next burst transaction is possible except Full FIFO)
>
> Value '1' is recommended to enhance the FIMC operation performance.
>
> Reviewed-by: Jonghun Han <jonghun.han@xxxxxxxxxxx>
> Signed-off-by: Hyunwoong Kim <khw0178.kim@xxxxxxxxxxx>
> ---
> This patch is depended on Hyunwoong Kim's last patch.
> - [PATCH v2] [media] s5p-fimc: Support stop_streaming and job_abort
>
> drivers/media/video/s5p-fimc/fimc-reg.c | 4 +++-
> drivers/media/video/s5p-fimc/regs-fimc.h | 1 +
> 2 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/s5p-fimc/fimc-reg.c b/drivers/media/video/s5p-fimc/fimc-reg.c
> index 88951b8..0eb9319 100644
> --- a/drivers/media/video/s5p-fimc/fimc-reg.c
> +++ b/drivers/media/video/s5p-fimc/fimc-reg.c
> @@ -457,7 +457,9 @@ void fimc_hw_set_in_dma(struct fimc_ctx *ctx)
> | S5P_MSCTRL_C_INT_IN_MASK
> | S5P_MSCTRL_2P_IN_ORDER_MASK);
>
> - cfg |= (S5P_MSCTRL_FRAME_COUNT(1) | S5P_MSCTRL_INPUT_MEMORY);
> + cfg |= (S5P_MSCTRL_FRAME_COUNT(1)
> + | S5P_MSCTRL_INPUT_MEMORY
> + | S5P_MSCTRL_FIFO_CTRL_FULL);
>
> switch (frame->fmt->color) {
> case S5P_FIMC_RGB565:
> diff --git a/drivers/media/video/s5p-fimc/regs-fimc.h b/drivers/media/video/s5p-fimc/regs-fimc.h
> index 28bd2fb..a984e81 100644
> --- a/drivers/media/video/s5p-fimc/regs-fimc.h
> +++ b/drivers/media/video/s5p-fimc/regs-fimc.h
> @@ -226,6 +226,7 @@
> #define S5P_MSCTRL_FLIP_X_MIRROR (1 << 13)
> #define S5P_MSCTRL_FLIP_Y_MIRROR (2 << 13)
> #define S5P_MSCTRL_FLIP_180 (3 << 13)
> +#define S5P_MSCTRL_FIFO_CTRL_FULL (1 << 12)
> #define S5P_MSCTRL_ORDER422_SHIFT 4
> #define S5P_MSCTRL_ORDER422_YCBYCR (0 << 4)
> #define S5P_MSCTRL_ORDER422_CBYCRY (1 << 4)
Applied. Thanks!
--
Sylwester Nawrocki
Samsung Poland R&D Center
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
