Re: [PATCH 2/4] media: i2c: imx415: Add missing ADBIT1 register for setup output format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alexander,

On 2/19/25 10:46, Alexander Shiyan wrote:
> The imx415 sensor has one more register for setting the output
> format (10/12 bit), which is currently not in the driver.
> The patch adds it.

the Fixes: tag may be justified here.

> Signed-off-by: Alexander Shiyan <eagle.alexander923@xxxxxxxxx>

Reviewed-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>

Thanks and best regards,
Michael

> ---
>  drivers/media/i2c/imx415.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
> index 16a52900c61c..c5beba4da18b 100644
> --- a/drivers/media/i2c/imx415.c
> +++ b/drivers/media/i2c/imx415.c
> @@ -77,6 +77,7 @@
>  #define IMX415_INCKSEL5		  CCI_REG8(0x311e)
>  #define IMX415_DIG_CLP_MODE	  CCI_REG8(0x32c8)
>  #define IMX415_WRJ_OPEN		  CCI_REG8(0x3390)
> +#define IMX415_ADBIT1		  CCI_REG8(0x3701)
>  #define IMX415_SENSOR_INFO	  CCI_REG16_LE(0x3f12)
>  #define IMX415_SENSOR_INFO_MASK	  0xfff
>  #define IMX415_CHIP_ID		  0x514
> @@ -581,6 +582,7 @@ static const struct cci_reg_sequence imx415_init_table[] = {
>  	{ IMX415_REVERSE, 0x00 },
>  	/* use RAW 10-bit mode */
>  	{ IMX415_ADBIT, 0x00 },
> +	{ IMX415_ADBIT1, 0x00 },
>  	{ IMX415_MDBIT, 0x00 },
>  	/* output VSYNC on XVS and low on XHS */
>  	{ IMX415_OUTSEL, 0x22 },





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux