On Thu, Feb 20, 2025, at 12:01, Hans Verkuil wrote: > On 20/02/2025 11:15, Hans Verkuil wrote: >> Hi Sebastian, Arnd, >> >> While cleaning up patchwork I stumbled on this PR. >> >> The odd thing is that the second patch (noinline) is committed, but not the first (avoid warning). >> >> Is it still needed? I'm not sure what happened here. >> >> The patch is still marked as 'New' in patchwork: >> >> https://patchwork.linuxtv.org/project/linux-media/patch/20241018152127.3958436-1-arnd@xxxxxxxxxx/ > > Apparently this just got lost somehow. I'll delegate this patch to me > and queue it up > for v6.15. I don't think this needs to go to v6.14 since I understand > it just kills > a warning. Thanks! I checked my local tree again, and this is indeed the last patch I have pending that addresses any -Wenum-compare-conditional warning. We have recently moved -Wenum-enum-conversion from W=1 to W=2, ideally we can move -Wenum-compare-conditional from W=1 to default once this patch is in. It's probably also a good time for me to switch my daily testing over from gcc to clang and see if any other -Wenum-compare-conditional warnings have come up. Arnd
