… > Update driver to use an asynchronous approach for decoding and feeding a > bitstream in order to achieve full capabilities of the device. > > Signed-off-by: Jackson.lee <jackson.lee@xxxxxxxxxxxxxxx> … Does a dot really belong to a personal name (according to the Developer's Certificate of Origin?) https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc2#n436 … > +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c … > +static void wave5_vpu_dec_feed_remaining(struct vpu_instance *inst) > +{ > + int ret = 0; May the initialisation be omitted for this local variable? > + struct v4l2_m2m_ctx *m2m_ctx = inst->v4l2_fh.m2m_ctx; > + u32 fail_res = 0; > + > + mutex_lock(&inst->feed_lock); > + ret = fill_ringbuffer(inst); > + mutex_unlock(&inst->feed_lock); … Under which circumstances would you become interested to apply a statement like “guard(mutex)(&inst->feed_lock);”? https://elixir.bootlin.com/linux/v6.13-rc2/source/include/linux/mutex.h#L201 Regards, Markus
