Hi Ricardo, On Tue, Dec 10, 2024 at 07:55:59PM +0000, Ricardo Ribalda wrote: > Provide an implementation of for_each_acpi_dev_match that can be used > when CONFIG_ACPI is not set. > > The condition `false && hid && uid && hrv` is used to avoid "variable > not used" warnings. > > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > --- > include/acpi/acpi_bus.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h > index b2e377b7f337..eaafca41cf02 100644 > --- a/include/acpi/acpi_bus.h > +++ b/include/acpi/acpi_bus.h > @@ -1003,6 +1003,9 @@ static inline int unregister_acpi_bus_type(void *bus) { return 0; } > > static inline int acpi_wait_for_acpi_ipmi(void) { return 0; } > > +#define for_each_acpi_dev_match(adev, hid, uid, hrv) \ > + for (adev = NULL; false && (hid) && (uid) && (hrv);) There should be a space after the semicolon. I guess this might depend on who you ask. Either way, Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > + > #endif /* CONFIG_ACPI */ > > #endif /*__ACPI_BUS_H__*/ > -- Regards, Sakari Ailus