We want to be able to compile_test the ipu6 driver in situations with !ACPI. In order to do this we had to add some conditional #ifs, which lead to false positives on the static analysers. Let's implement some helpers when !ACPI in the acpi headers to make the code more easier to maintain. We can land the first patch of this series ASAP to fix the current smatch warning. To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> To: Rafael J. Wysocki <rafael@xxxxxxxxxx> To: Len Brown <lenb@xxxxxxxxxx> To: Robert Moore <robert.moore@xxxxxxxxx> To: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Cc: linux-media@xxxxxxxxxxxxxxx Cc: linux-kernel@xxxxxxxxxxxxxxx Cc: linux-acpi@xxxxxxxxxxxxxxx Cc: acpica-devel@xxxxxxxxxxxxxxx Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> Changes in v3: - Prefer static inlines to macros (Thanks Rafael). - Link to v2: https://lore.kernel.org/r/20241122-fix-ipu-v2-0-bba65856e9ff@xxxxxxxxxxxx Changes in v2: - Add helpers in acpi to avoid conditional compilation - Link to v1: https://lore.kernel.org/r/20241122-fix-ipu-v1-1-246e254cb77c@xxxxxxxxxxxx --- Ricardo Ribalda (7): media: ipu-bridge: Fix warning when !ACPI ACPI: bus: implement for_each_acpi_dev_match when !ACPI ACPI: bus: implement acpi_get_physical_device_location when !ACPI ACPI: header: implement acpi_device_handle when !ACPI ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI ACPI: bus: implement acpi_device_hid when !ACPI media: ipu-bridge: Remove unneeded conditional compilations drivers/media/pci/intel/ipu-bridge.c | 28 +++++----------------------- include/acpi/acpi_bus.h | 23 ++++++++++++++++++++--- include/linux/acpi.h | 6 ++++++ 3 files changed, 31 insertions(+), 26 deletions(-) --- base-commit: 6c10d1adae82e1c8da16e7ebd2320e69f20b9d6f change-id: 20241122-fix-ipu-a2fe28908964 Best regards, -- Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
