Re: [PATCH v3 0/2] media: qcom: camss: Re-structure camss_link_entities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/11/2024 11:57, Vladimir Zapolskiy wrote:
Hi Vikram,

On 11/25/24 12:34, Vikram Sharma wrote:
Refactor the camss_link_entities function by breaking it down into
three distinct functions. Each function will handle the linking of
a specific entity separately, enhancing readability.

Changes in V3:
- Broke down the change in 2 patches. first one to functionally
decompose link error message. second to restrcture the link
function.
- Removed the declarion of camss_link_error from header file.
- Link to v2: https://lore.kernel.org/linux-arm- msm/20241112133846.2397017-1-quic_vikramsa@xxxxxxxxxxx/

as I said last time I don't see the value of these changes.

Since the changes are non-functional, then hopefully there should be
no issues with them, however I really miss the point of adding 65
lines of code for a questionable reason and at the price of increased
complexity.

Is there a good reason not to drop the series?
I think there is value in both functional decomposition and tidying up code - for example removing circuitous if/elses in favour of more discreet and easy to read functions, so I'm inclined to accept this series.

---
bod




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux