On 29/10/2024 13:10, Laurent Pinchart wrote: > On Tue, Oct 29, 2024 at 07:14:28AM +0100, Krzysztof Kozlowski wrote: >> On 28/10/2024 20:06, Mirela Rabulea wrote: >>> Add bindings for OX05B1S sensor driver >>> >>> Signed-off-by: Mirela Rabulea <mirela.rabulea@xxxxxxx> >> >> <form letter> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >> people, so fix your workflow. Tools might also fail if you work on some >> ancient tree (don't, instead use mainline) or work on fork of kernel >> (don't, instead use mainline). Just use b4 and everything should be >> fine, although remember about `b4 prep --auto-to-cc` if you added new >> patches to the patchset. >> >> You missed at least devicetree list (maybe more), so this won't be >> tested by automated tooling. Performing review on untested code might be >> a waste of time. >> >> Please kindly resend and include all necessary To/Cc entries. >> </form letter> >> >> Binding also looks very different than all other devices, so re-write it >> starting from EXISTING GOOD bindings. Not some downstream stuff. > > Krzysztof, please point to a good example when making this kind of > comment. Anything recently added. Git log tells which files were recently added. Best regards, Krzysztof
