On Fri, Oct 04, 2024 at 05:46:42PM +0300, Tomi Valkeinen wrote: > Add error handling for i2c read/write calls to > ub960_log_status_ub960_sp_eq() Missed period. ... > u8 eq_level; > s8 strobe_pos; > u8 v = 0; With that change in place you may remove redundant assignments to 0 here and everywhere else where is not needed anymore. > + int ret; > > /* Strobe */ > > - ub960_read(priv, UB960_XR_AEQ_CTL1, &v); > + ret = ub960_read(priv, UB960_XR_AEQ_CTL1, &v); > + if (ret) > + return; -- With Best Regards, Andy Shevchenko
