Re: [patch] [media] bttv: call mutex_init() on newly allocated lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 10, 2010 at 10:20:30AM +0300, Sergej Pupykin wrote:
> 
> Hi,
> 
> it looks better. Now only 3 oopses.

Heh.

Yeah.  Looking at it now, I can see why my patch was wrong.  That mutex
is supposed to get initialized in videobuf_queue_sg_init().  But we also
can't use the lock until after it's initialized.  This bug was
introduced in:

commit c37db91fd0d42d27141b6c49b768070df29e1c5e
Author: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
Date:   Wed Sep 15 08:18:31 2010 -0300

    V4L/DVB: bttv: fix driver lock and remove explicit calls to BKL
    
    Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>

I'm taking off for the weekend, so I won't be able to look at this
more until Monday.  See you then.  :)

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux