Hi, > On Tue, Sep 24, 2024 at 04:21:03PM +0200, Jacopo Mondi wrote: > > Hi Dan > > > > On Fri, Sep 20, 2024 at 01:41:15PM GMT, Daniel Scally wrote: > > > From: Daniel Scally <dan.scally+renesas@xxxxxxxxxxxxxxxx> > > > > > > Add support to the rzg2l-cru driver to capture 10/12/14 bit bayer > > > data and output it into the CRU's 64-bit packed pixel format. > > > > > > Signed-off-by: Daniel Scally <dan.scally+renesas@xxxxxxxxxxxxxxxx> > > > > Maybe I'm missing something for some previous series, but I see > > rzg2l_cru_csi2_setup() programming ICnMC with the UserDefined data > > type ? > > The function should use rzg2l_cru_ip_format.datatype << 16 (with an > appropriate register macro). I think I've commented on that in a previous > CRU patch series from Prabhakar, but I don't recall if the comment has > been addressed yet. > The comments has been addressed in patch [0](the series needs to be reviewed). [0] https://lore.kernel.org/all/20240910175357.229075-9-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/ Cheers, Prabhakar
