Hi Laurent, Thank you for the review. On Tue, Sep 24, 2024 at 11:46 PM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > On Tue, Sep 10, 2024 at 06:06:05PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Drop mutex while applying controls and just rely on > > pm_runtime_get_if_in_use() call. > > Here too the commit message should explain why the mutex can be dropped. > Given that it is only used in .s_ctrl(), and the control framework > serializes calls to the function, the mutex is not needed. > Agreed, I'll update the commit message as above and send a v3. Cheers, Prabhakar