Hi Fabio,
Thank you for the patch.
On Wed, Aug 07, 2024 at 03:26:10PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@xxxxxxx>
>
> Replace SET_RUNTIME_PM_OPS()/SET SYSTEM_SLEEP_PM_OPS() with their modern
> RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS() alternatives.
>
> The combined usage of pm_ptr() and RUNTIME_PM_OPS/SYSTEM_SLEEP_PM_OPS()
> allows the compiler to evaluate if the runtime suspend/resume() functions
> are used at build time or are simply dead code.
>
> This allows removing the __maybe_unused notation from the runtime
> suspend/resume() functions..
>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> index ba2e81f24965..d4a6c5532969 100644
> --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> @@ -693,7 +693,7 @@ static int imx8mq_mipi_csi_pm_resume(struct device *dev)
> return ret ? -EAGAIN : 0;
> }
>
> -static int __maybe_unused imx8mq_mipi_csi_suspend(struct device *dev)
> +static int imx8mq_mipi_csi_suspend(struct device *dev)
> {
> struct v4l2_subdev *sd = dev_get_drvdata(dev);
> struct csi_state *state = mipi_sd_to_csi2_state(sd);
> @@ -705,7 +705,7 @@ static int __maybe_unused imx8mq_mipi_csi_suspend(struct device *dev)
> return 0;
> }
>
> -static int __maybe_unused imx8mq_mipi_csi_resume(struct device *dev)
> +static int imx8mq_mipi_csi_resume(struct device *dev)
> {
> struct v4l2_subdev *sd = dev_get_drvdata(dev);
> struct csi_state *state = mipi_sd_to_csi2_state(sd);
> @@ -716,7 +716,7 @@ static int __maybe_unused imx8mq_mipi_csi_resume(struct device *dev)
> return imx8mq_mipi_csi_pm_resume(dev);
> }
>
> -static int __maybe_unused imx8mq_mipi_csi_runtime_suspend(struct device *dev)
> +static int imx8mq_mipi_csi_runtime_suspend(struct device *dev)
> {
> struct v4l2_subdev *sd = dev_get_drvdata(dev);
> struct csi_state *state = mipi_sd_to_csi2_state(sd);
> @@ -731,7 +731,7 @@ static int __maybe_unused imx8mq_mipi_csi_runtime_suspend(struct device *dev)
> return ret;
> }
>
> -static int __maybe_unused imx8mq_mipi_csi_runtime_resume(struct device *dev)
> +static int imx8mq_mipi_csi_runtime_resume(struct device *dev)
> {
> struct v4l2_subdev *sd = dev_get_drvdata(dev);
> struct csi_state *state = mipi_sd_to_csi2_state(sd);
> @@ -747,10 +747,9 @@ static int __maybe_unused imx8mq_mipi_csi_runtime_resume(struct device *dev)
> }
>
> static const struct dev_pm_ops imx8mq_mipi_csi_pm_ops = {
> - SET_RUNTIME_PM_OPS(imx8mq_mipi_csi_runtime_suspend,
> - imx8mq_mipi_csi_runtime_resume,
> - NULL)
> - SET_SYSTEM_SLEEP_PM_OPS(imx8mq_mipi_csi_suspend, imx8mq_mipi_csi_resume)
> + RUNTIME_PM_OPS(imx8mq_mipi_csi_runtime_suspend,
> + imx8mq_mipi_csi_runtime_resume, NULL)
> + SYSTEM_SLEEP_PM_OPS(imx8mq_mipi_csi_suspend, imx8mq_mipi_csi_resume)
> };
>
> /* -----------------------------------------------------------------------------
> @@ -958,7 +957,7 @@ static struct platform_driver imx8mq_mipi_csi_driver = {
> .driver = {
> .of_match_table = imx8mq_mipi_csi_of_match,
> .name = MIPI_CSI2_DRIVER_NAME,
> - .pm = &imx8mq_mipi_csi_pm_ops,
> + .pm = pm_ptr(&imx8mq_mipi_csi_pm_ops),
> },
> };
>
--
Regards,
Laurent Pinchart
