Re: [PATCH v1 1/2] media: camss: Increase the maximum frame size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/08/2024 16:24, Jordan Crouse wrote:
Commit 35493d653a2d
("media: camss: add support for vidioc_enum_framesizes ioctl") added a
maximum frame width and height but the values selected seemed to have
been arbitrary. In reality the cam hardware doesn't seem to have a maximum
size restriction so double up the maximum reported width and height to
allow for larger frames.

Also increase the maximum size checks at each point in the pipeline so
the increased sizes are allowed all the way down to the sensor.

So, I think this should be a Fixes: also.


Signed-off-by: Jordan Crouse <jorcrous@xxxxxxxxxx>
---

  drivers/media/platform/qcom/camss/camss-csid.c   | 8 ++++----
  drivers/media/platform/qcom/camss/camss-csiphy.c | 4 ++--
  drivers/media/platform/qcom/camss/camss-ispif.c  | 4 ++--
  drivers/media/platform/qcom/camss/camss-vfe.c    | 4 ++--
  drivers/media/platform/qcom/camss/camss-video.c  | 6 +++---
  5 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
index 858db5d4ca75..886c42c82612 100644
--- a/drivers/media/platform/qcom/camss/camss-csid.c
+++ b/drivers/media/platform/qcom/camss/camss-csid.c
@@ -752,8 +752,8 @@ static void csid_try_format(struct csid_device *csid,
  		if (i >= csid->res->formats->nformats)
  			fmt->code = MEDIA_BUS_FMT_UYVY8_1X16;
- fmt->width = clamp_t(u32, fmt->width, 1, 8191);
-		fmt->height = clamp_t(u32, fmt->height, 1, 8191);
+		fmt->width = clamp_t(u32, fmt->width, 1, 16383);
+		fmt->height = clamp_t(u32, fmt->height, 1, 16383);

Feels like we should have a define instead of hard coded values repeated constantly.

---
bod




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux