On 06/08/2024 23:42, Richard Acayan wrote:
The camera subsystem for the Snapdragon 670 is like on SDM845, but with
3 CSIPHY ports instead of 4. Add support for the SDM670 camera
subsystem.
"The camera subsystem for the SDM670 is the same as on SDM845 but, "
The naming should be consistent and the comma if you're using it should
come after not before the but.
Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx>
---
drivers/media/platform/qcom/camss/camss.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 51b1d3550421..05a47b82c012 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -2403,6 +2403,17 @@ static const struct camss_resources sdm660_resources = {
.link_entities = camss_link_entities
};
+static const struct camss_resources sdm670_resources = {
+ .version = CAMSS_845,
+ .csiphy_res = csiphy_res_845,
+ .csid_res = csid_res_845,
+ .vfe_res = vfe_res_845,
+ .csiphy_num = 3,
+ .csid_num = ARRAY_SIZE(csid_res_845),
+ .vfe_num = ARRAY_SIZE(vfe_res_845),
+ .link_entities = camss_link_entities
+};
+
static const struct camss_resources sdm845_resources = {
.version = CAMSS_845,
.csiphy_res = csiphy_res_845,
@@ -2447,6 +2458,7 @@ static const struct of_device_id camss_dt_match[] = {
{ .compatible = "qcom,msm8916-camss", .data = &msm8916_resources },
{ .compatible = "qcom,msm8996-camss", .data = &msm8996_resources },
{ .compatible = "qcom,sdm660-camss", .data = &sdm660_resources },
+ { .compatible = "qcom,sdm670-camss", .data = &sdm670_resources },
{ .compatible = "qcom,sdm845-camss", .data = &sdm845_resources },
{ .compatible = "qcom,sm8250-camss", .data = &sm8250_resources },
{ .compatible = "qcom,sc8280xp-camss", .data = &sc8280xp_resources },
Nice work, please fixup the commit long and add.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
