Re: [PATCH v2 2/2] media: imx335: Fix reset-gpio handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 29, 2024 at 02:13:15PM +0300, Laurent Pinchart wrote:
> > @@ -1171,7 +1171,7 @@ static int imx335_power_on(struct device *dev)
> >  	usleep_range(500, 550); /* Tlow */
> >  
> >  	/* Set XCLR */
> 
> I would replace this with
> 
> 	/* Deassert the reset (XCLR) signal. */
> 
> or something similar.

On my behalf the comment could be removed as well, it's not informative.

-- 
Sakari Ailus




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux