On Tue, Jul 2, 2024 at 8:15 AM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > > On Tue, Jul 2, 2024 at 7:34 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > On Tue, 2 Jul 2024 09:13:35 +0200 Christian König <christian.koenig@xxxxxxx> wrote: > > > > > yes that is > > > intentionally a define and not an inline function. > > > > > > See this patch here which changed that: > > > > > > commit 2c321f3f70bc284510598f712b702ce8d60c4d14 > > > Author: Suren Baghdasaryan <surenb@xxxxxxxxxx> > > > Date: Sun Apr 14 19:07:31 2024 -0700 > > > > > > mm: change inlined allocation helpers to account at the call site > > > > Dang, yes, that was a regrettable change. But hardly the end of the > > world. I do think each such alteration should have included a comment > > to prevent people from going and cleaning them up. > > Sorry I missed this discussion. Yes, the definition was intentional > and I will add comments for all the cases which were changed this way. Posted https://lore.kernel.org/all/20240703174225.3891393-1-surenb@xxxxxxxxxx/ adding clarifying comments. Thanks, Suren. > Thanks, > Suren. > > > > >
