Re: [PATCH] dma-buf: Remove unnecessary kmalloc() cast

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 01, 2024 at 11:26:34PM -0700, Andrew Morton wrote:
> No, I do think the cast is useful:
> 
> 	struct page *page = dma_fence_chain_alloc();
> 
> will presently generate a warning.  We want this.  Your change will
> remove that useful warning.
> 
> 
> Unrelatedly: there is no earthly reason why this is implemented as a
> macro.  A static inline function would be so much better.  Why do we
> keep doing this.

Agreed with all of the above.  Adding the dmabuf maintainers.




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux