On 01/07/2024 11:36, Krzysztof Kozlowski wrote: > On 28/06/2024 23:17, Spencer Hill wrote: >> Add bindings for Sony IMX728. >> >> Signed-off-by: Spencer Hill <shill@xxxxxxxxxxxxxxxxx> > > >> + >> + clocks: >> + description: Clock frequency from 18 to 30MHz >> + maxItems: 1 >> + >> + clock-names: >> + const: inck > > clock-names do not seem that useful - name is pretty obvious. Drop. ... and the binding was not tested. You must test them before asking maintainers to review. Otherwise we will just ignore the patches. :( Best regards, Krzysztof
