Hi Hans, Thanks for the review. On Mon, Jun 17, 2024 at 11:02:16AM +0200, Hans Verkuil wrote: > This needs a proper commit log. Oops. I thought this had been fixed already but I'll do that now. I'll use: The revert of patch "[media] media-device: dynamically allocate struct media_devnode" did not remove the kerneldoc documentation of the field media_dev in struct media_devnode. Do it now. > > Specifically it should mention that due to the revert in patch 05/26 > the media_dev field was deleted, but that that revert didn't remove it > from the kerneldoc comments. > > I would also suggest that you move this patch to 06/26 so that it > comes right after the 05/26 revert, since the two really belong together. I agree. > > With that, you can add my: > > Acked-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> Thank you! -- Kind regards, Sakari Ailus
